Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criteo self signed certificat #8

Merged
merged 10 commits into from Dec 5, 2014

Conversation

jmauro
Copy link

@jmauro jmauro commented Dec 4, 2014

PL linked to "Adding a CA for self signed certificates" #5

@zuazo
Copy link
Owner

zuazo commented Dec 4, 2014

Good work 👍 Please, can you document this in the README?

Bats tests runs simple bash instructions. For example, inside test/integration/self_certificate/bats/certificates_content_test.bats you can put the following:

@test "the certificate has the correct issuer" {
  openssl x509 -in /etc/ssl/certs/test.pem -noout -text \
    | grep -F 'Issuer: C=FR, ST=Ile de Paris, L=Paris, O=Toto, OU=Titi, CN=ca.test.com/emailAddress=titi@test.com'
}

@test "the certificate has the correct subject" {
  openssl x509 -in /etc/ssl/certs/test.pem -noout -text | grep -F 'Subject: [...]'
}

Then test this with $ kitchen verify self-certificate-....

But don't worry too much about the bats tests, I can take care of them.

@jmauro
Copy link
Author

jmauro commented Dec 5, 2014

I pushed tomorrow morning README + Bats test

@zuazo
Copy link
Owner

zuazo commented Dec 5, 2014

Thanks @jmauro, you are doing a great work!

@jmauro
Copy link
Author

jmauro commented Dec 5, 2014

OK guys it done but added the option 'with-ca' for certificat, I think it is more explicit.

Regards,
JM

@zuazo
Copy link
Owner

zuazo commented Dec 5, 2014

It is perfect now. Thanks you @jmauro!

I'm planning to release this in a couple of days, after some tests.

zuazo added a commit that referenced this pull request Dec 5, 2014
@zuazo zuazo merged commit f5615a9 into zuazo:master Dec 5, 2014
@zuazo
Copy link
Owner

zuazo commented Dec 30, 2014

Released in 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants