[RFC] Add ability to symbolize keys so it can be used with keyword args #275
+20
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #274
I am not sure if this is the way the maintainer wants to move on with the gem, but one approach would be adding a new argument for retro compatibility purposes and convert the argument if the argument is ready.
Essentially, I created this argument called
symbolize_args
and in case it was set, we'd symbolize the hash keys so before we actually send them to ActiveJob.Can I get some comments here if this is the way to move forward? I'll implement tests once confirmed.