Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to loosen the dependency on sacred #2

Closed
Agnes-U opened this issue Nov 30, 2022 · 1 comment
Closed

Suggest to loosen the dependency on sacred #2

Agnes-U opened this issue Nov 30, 2022 · 1 comment

Comments

@Agnes-U
Copy link

Agnes-U commented Nov 30, 2022

Hi, your project action_priors(commit id: c7ee56d) requires "sacred==0.8.1" in its dependency. After analyzing the source code, we found that the following versions of sacred can also be suitable, i.e., sacred 0.8.0, since all functions that you directly (5 APIs: sacred.ingredient.Ingredient.add_config, sacred.experiment.Experiment.log_scalar, sacred.observers.mongo.MongoObserver.init, sacred.experiment.Experiment.init, sacred.ingredient.Ingredient.capture) or indirectly (propagate to 33 sacred's internal APIs and 19 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on sacred from "sacred==0.8.1" to "sacred>=0.8.0,<=0.8.1". This will improve the applicability of action_priors and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on sacred?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?

@ondrejbiza
Copy link
Owner

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants