Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory not created before file_put_contents in PHP 5.6 when running convert.php #7

Open
Ronmi opened this issue Nov 23, 2015 · 1 comment

Comments

@Ronmi
Copy link

Ronmi commented Nov 23, 2015

Source files to be converted:

  • src/A.php
  • src/B/B.php

Command I use:

php convert.php src /tmp

It will produce warning like: file_put_contents(/tmp/B/B.php): failed to open stream: No such file or directory

By adding var_dump($file); to DirectoryBackporter.php Line 28, it dumps src/A.php, src/B/B.php, src/B. So the order is not what we expected.

I made some change to DirectoryBackporter.php, which can fix this bug in 5.6. I can send you PR if you think my code is okay to use.

@ondrejbouda
Copy link
Owner

Hi!

Your fix is good, I tested it. Please send PR. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants