Web SDK 109115 changes: #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jasonpang
commented
Feb 10, 2016
jasonpang
commented
- Allow customization of notify button's main button colors
- Can customize badge colors
- Cannot customize text hover popup colors
- Cannot customize dialog popup colors
- Add detection when manifest.json is served from a different origin (e.g. a CDN)
- Throws a friendly error message on the console
- Allow customization of notify button's main button colors
- Can customize badge colors
- Cannot customize text hover popup colors
- Cannot customize dialog popup colors
- Add detection when manifest.json is served from a different origin (e.g. a CDN)
- Throws a friendly error message on the console
|
Reviewed 5 of 5 files at r1. Comments from the review on Reviewable.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.