Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final merge still needs to be loaded into memory #1

Open
one-some opened this issue Jul 27, 2023 · 0 comments
Open

Final merge still needs to be loaded into memory #1

one-some opened this issue Jul 27, 2023 · 0 comments
Labels
enhancement New feature or request memory 200mb or bust

Comments

@one-some
Copy link
Owner

currently, the entire final merge still needs to be loaded into memory, be it gpu, disk, or cpu. theoretically, we can calculate the final weight values while only ever loading n weights at a time (merge targets).

torch.save/pickle seems to be a headache for that sort of thing (see the maybe-0b branch), unless we do shards or something. safetensors seeeeeeeeems more approachable for something like this as we (hopefully) wont have to muck about in pickle internals anymore.

@one-some one-some added enhancement New feature or request memory 200mb or bust labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request memory 200mb or bust
Projects
None yet
Development

No branches or pull requests

1 participant