Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leaks during indexing #2

Open
one-some opened this issue Jul 27, 2023 · 0 comments
Open

Memory leaks during indexing #2

one-some opened this issue Jul 27, 2023 · 0 comments
Labels
bug Something isn't working memory 200mb or bust

Comments

@one-some
Copy link
Owner

one-some commented Jul 27, 2023

it seems that during indexing facebook/opt-2.7b, there are two problems:

  • there's a memory usage spike of 5GB each time one of the archives is read (makes sense, this is probably the pickle file being deserialized)
  • memory usage permanently rises by 200-600MB (!!!) each time the model is indexed

the pickle spike is a little weird because in theory we're intercepting tensor creation stuff with the pickle patch/subclass thingey, so maybe its reading the file to a memory buffer somewhere for speed. in that case we might be able to use a streaming capable pickle module, but i do wonder what kind of effect that will have on one big tree-like object such as an nn.Module

the 500ish MB is a bit more concerning, no clue what could be causing that (caching?)

@one-some one-some added bug Something isn't working memory 200mb or bust labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working memory 200mb or bust
Projects
None yet
Development

No branches or pull requests

1 participant