-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oneTBB] Fix namespaces and headers #353
Conversation
const col_range_type& cols() const; | ||
}; | ||
} | ||
namespace oneapi{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space is missed before {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
namespace oneapi{ | |
namespace oneapi { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
||
namespace oneapi { | ||
namespace tbb { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we use indentation for nested namespaces? Some pages use it (see e.g. сontainers/concurrent_vector_cls.rst
@anton-potapov What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, some have indentation and some haven't. Let's choose one way, and I will fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed internally and decided to go as-is with this patch and fix indentation later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update dates in the license header of affected files
source/elements/oneTBB/source/task_scheduler/task_arena/task_scheduler_observer_cls.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR to the latest main branch (in order to resolve to conflicts)
- typo fix
|
||
std::allocator<int> alloc; | ||
|
||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrectly merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
# Conflicts: # source/elements/oneTBB/source/containers/concurrent_bounded_queue_cls/deduction_guides.rst # source/elements/oneTBB/source/containers/concurrent_hash_map_cls.rst # source/elements/oneTBB/source/containers/concurrent_multiset_cls.rst # source/elements/oneTBB/source/containers/concurrent_priority_queue_cls/deduction_guides.rst # source/elements/oneTBB/source/containers/concurrent_queue_cls/deduction_guides.rst # source/elements/oneTBB/source/containers/concurrent_set_cls.rst # source/elements/oneTBB/source/containers/concurrent_vector_cls/deduction_guides.rst # source/elements/oneTBB/source/task_scheduler/task_arena/task_arena_cls.rst Signed-off-by: Anton Potapov <anton.potapov@intel.com>
- fixed header name Signed-off-by: Anton Potapov <anton.potapov@intel.com>
This patch replaces tbb namespaces and headers with oneapi tbb.
Signed-off-by: Alexandra Epanchinzeva alexandra.epanchinzeva@intel.com