[oneMKL] Add BLAS APIs #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjohnson
force-pushed
the
main
branch
6 times, most recently
from
3c2ede7
to
91f0a87
Compare
mmeterel
reviewed
Nov 8, 2021
|
@aaronjohnson Maybe I missed it, but i did not see the changes needed for gemm_bias and trsm_batch. Please let me know if I missed them. Edit: My mistake, no edits are needed for trsm_batch and gemm_bias. Could you please remove the unnecessary copies of exceptions in trsm_batch? |
lhuot
reviewed
Nov 9, 2021
mmeterel
reviewed
Nov 9, 2021
mmeterel
reviewed
Nov 10, 2021
mmeterel
approved these changes
Nov 10, 2021
mmeterel
approved these changes
Nov 10, 2021
mmeterel
reviewed
Nov 10, 2021
| The queue where the routine should be executed. | ||
|
|
||
| upper_lower | ||
| Array of group_count onemkl::upper_lower |
There was a problem hiding this comment.
group_count onemkl::upper_lower
There was a problem hiding this comment.
put these inside ticks pls. Looks at the other parameters for reference.
| upper_lower | ||
| Array of group_count onemkl::upper_lower | ||
| values. ``upper_lower[i]`` specifies whether data in C for every | ||
| matrix in group ``i`` is in upper or lower triangle form. |
|
@rscohn2 this is the PR I have been talking with you about. They are going to clean up the commit message and we will merge it early this morning. |
|
I've rebase+squashed all the commits on the PR into one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding BLAS APIs now in oneMKL product to the specification.