Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KNN Optional result and search #1741

Merged
merged 122 commits into from Aug 4, 2021
Merged

KNN Optional result and search #1741

merged 122 commits into from Aug 4, 2021

Conversation

KulikovNikita
Copy link
Contributor

Depends on this PR

Ruslan Israfilov and others added 30 commits May 18, 2021 01:52
Proposal for optional results
afed28b
Merge remote-tracking branch 'rlnx/optional-results' into dev/knn/opt…
a7524fb 
…ional-results
Changes
d77cc79
@PetrovKP
add search and cosine
727bc5e
@PetrovKP
fix ci
853e4ae
@PetrovKP
Merge branch 'master' of https://github.com/oneapi-src/oneDAL into co…
87ec84c 
…sine_distance
@PetrovKP
improve; fix; perf optimization
963846c
@PetrovKP
merge + fixes
6e804f2
@PetrovKP
ref examples
0c9f405
@PetrovKP
fix ci
9f001f5
@PetrovKP
fix ci
f4d55ad
@PetrovKP
add to BUILD
9f271c0
@PetrovKP
fix bazel tests
8b8c626
@PetrovKP
fixes
7f5bde6
@PetrovKP
fixes
6160b4a
@PetrovKP
Update knn_search_brute_force_dense_batch.cpp
9244a78
@PetrovKP
move max to finalize
9bfedf7
@PetrovKP
apply comments
82d332c
minor changes
415314a
Merge remote-tracking branch 'petrov/cosine_distance' into dev/knn/op…
07d10a9 
…tions
Minor changes
af25fdc
Changes to enable merge
8a8bcb5
Working
08ff2db
@PetrovKP
apply
f4c6549
Default optional results
c25777f
GPU is working
dfd662b
Clang format applied
7588637
Merge remote-tracking branch 'petrov/cosine_distance' into dev/knn/op…
4f566b8 
…tions
Clang format applied to example
dc23b31
Minor improvements
20309cd
@KulikovNikita
Copy link
Contributor Author

/intelci: run

@KulikovNikita
Copy link
Contributor Author

/intelci: run

@KulikovNikita
Copy link
Contributor Author

/intelci: run

@KulikovNikita
Copy link
Contributor Author

/intelci: run

@KulikovNikita
Copy link
Contributor Author

/intelci: run

1 similar comment
@KulikovNikita
Copy link
Contributor Author

/intelci: run

@KulikovNikita
Copy link
Contributor Author

/intelci: run

@rlnx
Update cpp/oneapi/dal/algo/knn/common.hpp
b7df365 
Co-authored-by: Ruslan Israfilov <ruslan.is@outlook.com>
@KulikovNikita
Copy link
Contributor Author

/intelci: run

@KulikovNikita
Copy link
Contributor Author

/intelci: run

1 similar comment
@KulikovNikita
Copy link
Contributor Author

/intelci: run

@PetrovKP
Copy link
Contributor

PetrovKP commented Aug 4, 2021

you have segafault on gen9 with sklearnex. try rebase this PR and rerun CI

@KulikovNikita
Copy link
Contributor Author

/intelci: run

@KulikovNikita KulikovNikita merged commit 6d631ce into oneapi-src:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KalyanovD KalyanovD KalyanovD left review comments

@rlnx rlnx rlnx approved these changes

@PetrovKP PetrovKP PetrovKP approved these changes

@amgrigoriev amgrigoriev amgrigoriev approved these changes

@averbukh averbukh Awaiting requested review from averbukh

@Vika-F Vika-F Awaiting requested review from Vika-F Vika-F is a code owner

@michael-smirnov michael-smirnov Awaiting requested review from michael-smirnov

@outoftardis outoftardis Awaiting requested review from outoftardis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@KulikovNikita @outoftardis @rlnx @PetrovKP @KalyanovD @amgrigoriev