Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KT][ESIMD Sort] Code quality improvements #1311

Open
dmitriy-sobolev opened this issue Dec 11, 2023 · 0 comments
Open

[KT][ESIMD Sort] Code quality improvements #1311

dmitriy-sobolev opened this issue Dec 11, 2023 · 0 comments
Assignees

Comments

@dmitriy-sobolev
Copy link
Contributor

dmitriy-sobolev commented Dec 11, 2023

These are the gaps which remain after the main review (#1257):

  1. Separate declaration and definition (can be postponed until productization):
    See discussion: [KT] ESIMD-based radix sort kernel templates #1257 (comment).
  2. Use zip_iterator/zip_view instead of __rng_pack:
    See discusison: [KT] ESIMD-based radix sort kernel templates #1257 (comment) and [KT] ESIMD-based radix sort kernel templates #1257 (comment).
  3. Consolidate trivial checks for the sequence length (see the checks like if (__keys_last - __keys_first < 2)).
  4. Refactor __onesweep_memory_holder class.
    See discussion: [KT] ESIMD-based radix sort kernel templates #1257 (comment).
  5. Consider renaming __vector_store overloads to denote that they work with SLM.
    See discussion: [KT] ESIMD-based radix sort kernel templates #1257 (comment).
  6. Get rid of loops in __one_wg_kernel and use native functions or helper wrappers where possible. Avoid bitcasts to uint32_t.
    See discussion: [KT] ESIMD-based radix sort kernel templates #1257 (comment)
  7. Make _ONEDPL_ESIMD_INLINE a genera macro to enforce inlining or replace it if there is an existing one.
    See discussion: [KT] ESIMD-based radix sort kernel templates #1257 (comment)
@dmitriy-sobolev dmitriy-sobolev self-assigned this Dec 11, 2023
@dmitriy-sobolev dmitriy-sobolev changed the title [KT][ESIMD Sort] Improve code quality [KT][ESIMD Sort] Code quality improvements Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant