Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage of input data processing types in oneDPL unit testing with dpcpp backend #1414

Closed
danhoeflinger opened this issue Feb 21, 2024 · 1 comment · Fixed by #1429

Comments

@danhoeflinger
Copy link
Contributor

danhoeflinger commented Feb 21, 2024

Capturing this comment as an issue:

Perhaps it makes sense to have a unit test targeted specifically at handling different input types and covering __get_sycl_range combinations using a simple lightweight API call and a device policy.

Originally posted by @danhoeflinger in #1413 (comment)

I would like us to improve our testing coverage by calling a simple API (like copy) with a variety of combinations of input types, USM data, sycl_iterators, host_iterators, reverse_iterators, fancy_iterators, nested fancy_iterators, to better catch issues in oneDPL's input data processing for dpcpp backend.

@danhoeflinger
Copy link
Contributor Author

@SergeyKopienko, I'd like to get your take on this. If there already exists something like this, or if you have ideas on how this would best augment our current testing.

@danhoeflinger danhoeflinger linked a pull request Mar 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant