Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful shutdown #50

Closed
cressie176 opened this issue May 16, 2019 · 1 comment
Closed

Graceful shutdown #50

cressie176 opened this issue May 16, 2019 · 1 comment

Comments

@cressie176
Copy link
Collaborator

cressie176 commented May 16, 2019

Currently shutting down the rascal broker will

  1. Unsubscribe all subscriptions
  2. Disconnect from all vhosts

This means any in-flight unacknowledged messages will be rolled back (and redelivered), and the outcome of any inflight publications is unknown.

It will never be possible to shutdown in a completely graceful manner since Rascal is not responsible for the full unit of work, but it should be possible to delay disconnect until

  1. All in-flight messages have been ack'd/nack'd (or a timeout expires)
  2. All borrowed publication channels have been returned to the pool (or a timeout expires)

The former would require counting messages in and out. The latter requires setting the channel publication pool to drain after pausing channel allocation.

Thoughts @BorePlusPlus ?

@cressie176
Copy link
Collaborator Author

The next release of Rascal drains the publication channel pools and waits a configurable period of time between unsubscribing and disconnecting to allow inflight messages to be ack/nackd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant