Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos preventing successful build #27

Closed
saltymouse opened this issue Feb 10, 2020 · 2 comments
Closed

Fix typos preventing successful build #27

saltymouse opened this issue Feb 10, 2020 · 2 comments

Comments

@saltymouse
Copy link
Contributor

Brilliant Craft 3 starter—one of the few that actually works as expected!

When spinning it up on my machine, I noticed two simple typos that prevented successful building, however.

I have a branch on my fork with these changes fixed if you'd like a pull-request.

@johndwells
Copy link
Contributor

@saltymouse Thanks for the contributions! Nice catch, I'd be happy to merge your pull request.

Admittedly, the front-end build stuff we haven't really tested or used much, our focus has mostly been on dialing in the Craft setup. I'm happy to hear you've found it useful!

@johndwells
Copy link
Contributor

@saltymouse Finally got around to merging your fix - thanks again for your contribution!

As I said, this is still a relatively under-baked side of this repo. The Craft side is pretty active, but I'm not 100% happy with the front-end build setup. Always happy to have feedback. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants