Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change jinja block delimiters #1175

Closed
onedr0p opened this issue Jan 16, 2024 · 4 comments · Fixed by #1269 or #1326
Closed

Change jinja block delimiters #1175

onedr0p opened this issue Jan 16, 2024 · 4 comments · Fixed by #1269 or #1326
Assignees
@onedr0p
Labels
area/bootstrap Changes made in the bootstrap directory

Comments

@onedr0p
Copy link
Owner

onedr0p commented Jan 16, 2024 •
edited
Loading

PR was merged to ignore these blocks in YAML but we need to wait for a release, and for the renovate app to be updated to it. Waiting on renovate 37.137.3

renovatebot/renovate#26682

https://developer.mend.io/github/onedr0p/flux-cluster-template/ is currently on 37.153.2
@onedr0p onedr0p added area/bootstrap Changes made in the bootstrap directory hold/upstream labels Jan 16, 2024
@prehor
Copy link
Contributor

prehor commented Jan 20, 2024

Renovate 37.137.3 includes your renovatebot/renovate/pull/26682

@onedr0p
Copy link
Owner Author

onedr0p commented Jan 20, 2024

Yep! I am just waiting for their hosted renovate platform to update to it.

@onedr0p onedr0p changed the title Move jinja block delimiters back to {% ... %} once renovate released Move jinja block delimiters back to {% ... %} once renovate releases 37.137.3 Jan 22, 2024
@onedr0p onedr0p self-assigned this Jan 23, 2024
@onedr0p onedr0p mentioned this issue Jan 29, 2024
Merged
@onedr0p
Copy link
Owner Author

onedr0p commented Jan 29, 2024 •
edited
Loading

I went ahead and made these changes even though the renovate app is not updated to the version needed. Once it is updated updates should start to roll in for templates with the jinja delimiters

@onedr0p
Copy link
Owner Author

onedr0p commented Feb 15, 2024 •
edited
Loading

Judging by the logs it doesn't look like Renovate can still properly handle these delimiters. I probably have to move back to

#{ ... }# and #< ... >#

@onedr0p onedr0p reopened this Feb 15, 2024
@onedr0p onedr0p changed the title Move jinja block delimiters back to {% ... %} once renovate releases 37.137.3 Change jinja block delimiters Feb 15, 2024
@onedr0p onedr0p mentioned this issue Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onedr0p onedr0p

Labels
area/bootstrap Changes made in the bootstrap directory
Projects
None yet
Milestone
No milestone
2 participants
@onedr0p @prehor