Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

digestURI when signing #165

Closed
michuynh opened this issue Apr 30, 2018 · 2 comments
Closed

digestURI when signing #165

michuynh opened this issue Apr 30, 2018 · 2 comments

Comments

@michuynh
Copy link

Hello,

When handling signature part when generating the SP metadata, in java file "Util.java", at line executing "sig.addDocument(reference, transforms, Constants.SHA1);", is this normal that the digestURI parameter (Constants.SHA1) is hard-coded? Is it not depending on the signature algorithm provided in the properties file/certificate?

Regards,
@pitbulk
Copy link
Contributor

pitbulk commented Apr 30, 2018

The signMetadata method accepts a signAlgorithm parameter, but the digest method is hardcoded to Constants.SHA1 on the addSign method.

We should improve the addSign and signAlgorithm method to accept a digestAlgorithm parameter as well.

@pitbulk
Copy link
Contributor

pitbulk commented Jul 7, 2018

Implemented 21b6b9e

@pitbulk pitbulk closed this as completed Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pitbulk @michuynh