Issues with PowerMock

[pitbulk]

This toolkit uses PowerMock in order to test its methods.

There are some problems with PowerMock described in the documentation.

We should find a way to fix those problems. Right now it seems is not possible to execute test on Java8 (Java7 requires a extra command to disable the bytecode verification.

[luuuis]

Are you open to removing PowerMock completely? I have found that it is not necessary to use byte code manipulation when the code being tested is designed with testing in mind.

For java-saml this might mean introducing some interfaces instead of using classes directly.

[pitbulk]

If you review the unit test you will see that I added PowerMock in order to be able to simulate HTTP Requests. How is your proposal to manage it?

Im open to suggestions, I dont consider me as a Java expert.

This java-saml toolkit is a port of the PHP/Python toolkits and I tried to implement as similar as possible in order to help me with the global maintenance so when I include a new feature in one I port the functionality on the rest.

The main goal is to keep the toolkit as simple as possible and cover most of the scenarios that normal SAML integrations requires. There are alternatives for the Onelogin's toolkits in all the languages but I saw that many customers decide to use them due the simplicity.

[luuuis]

I think we can close this :)