Support more complex response statuses in LogoutResponse generation #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An overload of build() has been added to supply a SamlResponseStatus, so that it's possible to specify a more complex response status in the generated LogoutResponse. A typical example is the case of a partial logout, which needs a top-level urn:oasis:names:tc:SAML:2.0:status:Responder status code and a second-level urn:oasis:names:tc:SAML:2.0:status:PartialLogout one. Also, a status message can also be added now. Closes SAML-Toolkits#342.
pitbulk
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An overload of build() has been added to supply a SamlResponseStatus,
so that it's possible to specify a more complex response status in the
generated LogoutResponse. A typical example is the case of a partial
logout, which needs a top-level
urn:oasis:names:tc:SAML:2.0:status:Responder status code and a
second-level
urn:oasis:names:tc:SAML:2.0:status:PartialLogout one. Also, a status
message can also be added now.
Closes #342.