Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more decimal places for seconds #250

Closed
jalan opened this issue Jun 27, 2019 · 2 comments
Closed

Support more decimal places for seconds #250

jalan opened this issue Jun 27, 2019 · 2 comments

Comments

@jalan
Copy link

jalan commented Jun 27, 2019

OneLogin_Saml2_Utils.parse_SAML_to_time currently supports two formats:

  • %Y-%m-%dT%H:%M:%SZ
  • %Y-%m-%dT%H:%M:%S.%fZ

We're seeing Azure AD send timestamps like 2019-06-26T14:19:51.2123335Z in its SAML responses, with seven decimal digits. This is odd, but some other SAML tools accept it.

@jalan
Copy link
Author

jalan commented Jun 27, 2019

My mistake, it wasn't Azure sending these odd timestamps, but some other unknown IDP. In any case, many other SAML tools accept an arbitrary number of decimal digits, it seems.

@charleslavon
Copy link

@pitbulk what are your thoughts on this issue and the corresponding PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants