Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeprecationWarning: defusedxml.lxml #267

Closed
mel-mason opened this issue Feb 6, 2020 · 2 comments
Closed

DeprecationWarning: defusedxml.lxml #267

mel-mason opened this issue Feb 6, 2020 · 2 comments

Comments

@mel-mason
Copy link

I just got a deprecation warning when checking my django project:

DeprecationWarning: defusedxml.lxml is no longer supported and will be removed in a future release

It looks like it comes from this package - specifically the from defusedxml.lxml import fromstring imports in several files. (See https://github.com/onelogin/python-saml/search?q=defusedxml.lxml&unscoped_q=defusedxml.lxml)

Are there any plans to remove this dependency on defusedxml.lxml? I see it's been discussed in #221 , but that seems to be pre-deprecation.

Thanks for all your work on this project
@pitbulk
Copy link
Contributor

pitbulk commented Feb 6, 2020

No plans right now.

See SAML-Toolkits/python3-saml#159

@pitbulk
Copy link
Contributor

pitbulk commented Jan 3, 2021

cElementTree was removed in Python 3.9. See tiran/defusedxml#50

pitbulk added a commit that referenced this issue Jan 7, 2021
@pitbulk
See #221 and #267. Custom lxml parser based on the one defined at xml…
64fbe77 
…defused. Parser will ignore comments and processing instructions and by default have deactivated huge_tree, DTD and access to external documents
pitbulk added a commit that referenced this issue Jan 12, 2021
@pitbulk
Merge pull request #278 from onelogin/xmlparser
4a3efac 
See #221 and #267. Custom lxml parser based on the one defined at xmldefused
@pitbulk pitbulk closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pitbulk @mel-mason