AttributeConsumingService support. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First pass at adding AttributeConsumingService support in the AuthnRequest.
Feature/requested attrib support, feature branch -> master branch
Conflicts: setup.py
| @@ -119,7 +182,7 @@ def builder(sp, authnsign=False, wsign=False, valid_until=None, cache_duration=N | |||
| str_contacts = '\n'.join(contacts_info) | |||
|
|
|||
| metadata = """<?xml version="1.0"?> | |||
| <md:EntityDescriptor xmlns:md="urn:oasis:names:tc:SAML:2.0:metadata" | |||
| <md:EntityDescriptor xmlns:md="urn:oasis:names:tc:SAML:2.0:metadata" xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion" | |||
There was a problem hiding this comment.
Can we add xmlns:saml namespace here only if attribute_consuming_service defined?
There was a problem hiding this comment.
Sure, i'll add that in.
added 4 commits
February 16, 2016 11:49
|
@pitbulk please review added new unti tests - circle-ci now passes |
|
ping @pitbulk any further comments on this? |
|
Hi @jimmyislive I had no time to review it. It will take some time, right now focus on other tasks sorry. |
|
At python3-saml we following a XML template strategy, but here we build the XML by concat strings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.