Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax nokogiri version requirement to >= 1.5.0 #107

Merged
merged 1 commit into from
Feb 24, 2014

Conversation

Lordnibbler
Copy link
Contributor

No description provided.

@todd-richmond
Copy link

does the Gemfile change need to be >= as well?

@Lordnibbler
Copy link
Contributor Author

@todd-richmond as I mentioned in #106 the Gemfile needs to be ~> 1.5 as this is latest major version that will compile on Ruby 1.8.7 AND 1.9.3, thus allowing our Travis CI build to pass. Is this solution OK for you?

@todd-richmond
Copy link

I'll give it a try in the next build - thx

@Lordnibbler
Copy link
Contributor Author

@todd-richmond thanks, sooner you let me know sooner I can merge it 😸

@Lordnibbler
Copy link
Contributor Author

@todd-richmond any updates? would like to merge this today

@Lordnibbler
Copy link
Contributor Author

Going to go ahead and merge for now as its critical we get a new version of the branch cut with this change today. Please let me know if this works for you @todd-richmond

Lordnibbler pushed a commit that referenced this pull request Feb 24, 2014
Relax nokogiri version requirement to >= 1.5.0
@Lordnibbler Lordnibbler merged commit 2016b77 into master Feb 24, 2014
@todd-richmond
Copy link

Sorry - no luck. Bundler still wants to choose nokogiri 1.5 by default when using Ruby 2.0. However, I was able to force the newer nokogiri by setting 1.6 in Gemfile

@Lordnibbler
Copy link
Contributor Author

@todd-richmond I think that is the best bet for now, unless this is a blocker for you for another reason? We have to allow Ruby 1.8.7 users to use Nokogiri 1.5.x still. Do you have any better ideas?

@todd-richmond
Copy link

Not a blocker for me now, but others will probably run into the same problem. 1.8.7 was retired mid last year and is strongly discouraged: https://www.ruby-lang.org/en/news/2013/06/30/we-retire-1-8-7/

Anyone using 1.8.7 is probably gem locked to old versions of your gem as well

@Lordnibbler
Copy link
Contributor Author

@todd-richmond OK, I will add this info to the readme as a workaround for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants