Relax nokogiri gem requirements #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lordnibbler
force-pushed
the
relax-nokogiri-requirement
branch
from
61653c4
to
697c62a
Compare
|
@Lordnibbler, good change for the version. That helps me in my case where the app is sitting at |
|
@elskwid yes, sorry about this -- it was an overlooked change when we switched to Minitest. |
| # 1.8.7 | ||
| s.add_runtime_dependency('nokogiri', '~> 1.5.10') | ||
| else | ||
| s.add_runtime_dependency('nokogiri', '~> 1.6') |
There was a problem hiding this comment.
Shouldn't this be ~> 1.6.0? Without using the patch-level identifier, this runs the risk of v1.7+ breaking something in the future. Otherwise you could remove the conditional and just use ~> 1.5 and that should satisfy everything Ruby 1.8+.
There was a problem hiding this comment.
@phlipper I will make the change to ~> 1.6.0, but unfortunately setting it to ~> 1.5 will still cause Ruby 1.8 to try to install Nokogiri 1.6.x, despite it not being compatible :(
|
👍 |
Lordnibbler
force-pushed
the
relax-nokogiri-requirement
branch
from
8171a14
to
697c62a
Compare
- dont use weird array syntax for dependency definitions
Lordnibbler
force-pushed
the
relax-nokogiri-requirement
branch
from
697c62a
to
2738132
Compare
Lordnibbler
changed the title
Lordnibbler
added a commit
that referenced
this pull request
Feb 10, 2015
Relax nokogiri gem requirements
Lordnibbler
referenced
this pull request
in 01Click/ruby-saml
Feb 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Adjust
nokogirigem requirement:Todos