Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require ‘net/http’ library #204

Merged
merged 4 commits into from Mar 17, 2015
Merged

Require ‘net/http’ library #204

merged 4 commits into from Mar 17, 2015

Conversation

rafaelgonzalez
Copy link
Contributor

The only place where Net::HTTP is used is in lib/ruby-saml/idp_metadata_parser.rb, so this is where I require the net/http library.

@rafaelgonzalez rafaelgonzalez mentioned this pull request Mar 17, 2015
Closed
@rafaelgonzalez rafaelgonzalez changed the title [WIP] Require ‘net/http’ library Require ‘net/http’ library Mar 17, 2015
pitbulk added a commit that referenced this pull request Mar 17, 2015
@pitbulk
Merge pull request #204 from rafaelgonzalez/require-net-http
d57a8e4 
Require ‘net/http’ library
@pitbulk pitbulk merged commit d57a8e4 into SAML-Toolkits:master Mar 17, 2015
@Lordnibbler
Copy link
Contributor

Thank you for this PR, @rafaelgonzalez

@rafaelgonzalez rafaelgonzalez deleted the require-net-http branch March 17, 2015 22:45
@rafaelgonzalez
Copy link
Contributor Author

Cheers 🍻

@Umofomia Umofomia mentioned this pull request Apr 1, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rafaelgonzalez @Lordnibbler @pitbulk