Allow logging to be delegated to an arbitrary Logger #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pitbulk - any objection to this change? It seems harmless, and allows for smoother integration with the host app's logging. |
|
@tony-spataro-rs thanks for this contribution -- I'm ok with it if you could just add some information to the readme on how to use this new logging feature. Thanks |
|
@Lordnibbler done; |
!
ghost
force-pushed
the
configurable_logging
branch
from
1cf4ef8
to
393c0e7
Compare
|
@Lordnibbler or @pitbulk - any chance of getting this merged before the next release? |
|
thanks, unfortunately in order to merge this branch we will need to rebase it off of |
stevecrozz
force-pushed
the
configurable_logging
branch
from
393c0e7
to
17d7073
Compare
stevecrozz
force-pushed
the
configurable_logging
branch
from
17d7073
to
527ef3f
Compare
|
@Lordnibbler I rebased these changes onto master |
pitbulk
added a commit
that referenced
this pull request
Jun 30, 2015
Allow logging to be delegated to an arbitrary Logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.