Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 100% test coverage on Response class #240

Merged
merged 1 commit into from
Jun 9, 2015
Merged

Conversation

pitbulk
Copy link
Collaborator

@pitbulk pitbulk commented Jun 9, 2015

  • Added base64 xml files for testing.
  • Added tests.

Resume of the current test_coverage:
https://s3.amazonaws.com/uploads.hipchat.com/9484/596130/yyCmNYy9okTcirS/ruby_saml_test_coverage.png

@luisvm
Copy link
Contributor

luisvm commented Jun 9, 2015

👍 looks good!

pitbulk added a commit that referenced this pull request Jun 9, 2015
Add 100% test coverage on Response class
@pitbulk pitbulk merged commit 70f5d77 into master Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants