Security improvement: Avoid entity expansion (XEE attacks) #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitbulk
added a commit
that referenced
this pull request
Jun 30, 2015
Security improvement: Avoid entity expansion (XEE attacks)
|
Should a CVE be requested for this? |
|
👍 to request and assign a CVE as it seems like the older versions have potential security impact. |
|
@reedloden hey reed, we meet again :D. if you're doing the CVE, this is my stab at the CVSS vector https://nvd.nist.gov/cvss.cfm?calculator&version=2&vector=(AV:N/AC:L/Au:N/C:N/I:N/A:P/E:POC/RL:OF/RC:C) |
|
I requested one in http://seclists.org/oss-sec/2015/q3/70. Good to hear from you, @CalebFenton! I linked to this pull request from my CVE request, so hopefully NIST will see this when they do NVD advisories for the eventual CVE (and assign a CVSSv2 score). |
|
I also opened up #252 to figure out a better process for handling security issues going forward. |
amoose
added a commit
to amoose/ruby-saml
that referenced
this pull request
Aug 4, 2015
amoose
added a commit
to amoose/ruby-saml
that referenced
this pull request
Aug 4, 2015
rspeicher
added a commit
to gitlabhq/gitlabhq
that referenced
this pull request
Aug 17, 2015
Updates a vulnerable `ruby-saml` dependency. - SAML-Toolkits/ruby-saml@9853651 - SAML-Toolkits/ruby-saml#247
rspeicher
pushed a commit
to gitlabhq/gitlabhq
that referenced
this pull request
Aug 17, 2015
Bump omniauth-saml to 1.4.1 Updates a vulnerable `ruby-saml` dependency. - SAML-Toolkits/ruby-saml@9853651 - SAML-Toolkits/ruby-saml#247 See merge request !1162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related info of XEE attacks:
http://web-in-security.blogspot.de/2014/11/detecting-and-exploiting-xxe-in-saml.html
http://www.vsecurity.com/download/papers/XMLDTDEntityAttacks.pdf
http://websec.io/2012/08/27/Preventing-XEE-in-PHP.html