Expose NameID Format on SloLogoutrequest #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equivalent to `name_id_format` (`nameid_format`) on `Response` class.
pitbulk
reviewed
Oct 9, 2017
test/logout_requests/slo_request.xml
Outdated
| @@ -1,4 +1,4 @@ | |||
| <samlp:LogoutRequest Version='2.0' ID='_c0348950-935b-0131-1060-782bcb56fcaa' xmlns:samlp='urn:oasis:names:tc:SAML:2.0:protocol' IssueInstant='2014-03-21T19:20:13'> | |||
| <saml:Issuer xmlns:saml='urn:oasis:names:tc:SAML:2.0:assertion'>https://app.onelogin.com/saml/metadata/SOMEACCOUNT</saml:Issuer> | |||
| <saml:NameID xmlns:saml='urn:oasis:names:tc:SAML:2.0:assertion'>someone@example.org</saml:NameID> | |||
| <saml:NameID xmlns:saml='urn:oasis:names:tc:SAML:2.0:assertion' Format='urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress'>someone@example.org</saml:NameID> | |||
There was a problem hiding this comment.
can you create a new xml instead modify it?
slo_request.xml is related to slo_request.xml.base64 and slo_request_deflated.xml.base64
Use a separate XML file for SloLogoutrequest#name_id_format tests. Apparently there are various representations of the file that I modified that are all supposed to be equivalent.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
?? READY/IN DEVELOPMENT/HOLD
Migrations
NO
Description
Expose NameID Format on
SloLogoutrequest.This is equivalent to the
name_id_format(nameid_format) methods onResponseclass. Clients are likely to need access to this (I did) for the same reasons as they need it onResponse.