[Review] Request from 'digitaltom' @ 'digitaltom/ruby-saml/review_130904_allow_for_settings_authn_context_and_settings_authn_context_decl_ref' #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@digitaltom can you please rebase off the current master (just released |
…text_and_settings_authn_context_decl_ref
|
@Lordnibbler fixed, please check again. |
|
@luisvm @inakidelamadrid @pitbulk can you review please? looks ok to me 👍 |
|
@luisvm @inakidelamadrid @pitbulk review please |
|
👍 |
1 similar comment
|
👍 |
|
@pitbulk any word on this PR? |
|
@pitbulk please review so we can merge! |
| should "create the saml:AuthnContextDeclRef element correctly" do | ||
| settings = OneLogin::RubySaml::Settings.new | ||
| settings.idp_sso_target_url = "http://example.com" | ||
| settings.authn_context_decl_ref = 'suse' |
There was a problem hiding this comment.
Instead of 'suse' use 'http://example.com/declaration_ref'
(review the test)
|
There is no documentation on the PR, neither example values for the fields. |
|
I gonna close this PR, we will merge #152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a AuthnContextDeclRef element inside RequestedAuthnContext.
It looks like this:
We need that for choosing a login page on our saml provider on sp initiated requests.