Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disassemble logging "error" on REL addressing mode #46

Closed
fabriciorby opened this issue Aug 22, 2022 · 2 comments
Closed

Disassemble logging "error" on REL addressing mode #46

fabriciorby opened this issue Aug 22, 2022 · 2 comments

Comments

@fabriciorby
Copy link

I am using this project as a model to create a NES emulator using Java.

There's something happening here, when I run the code showed in the video value should be -6, but it's going as 250. Which causes inaccurate logging.
https://github.com/OneLoneCoder/olcNES/blob/master/Part%232%20-%20CPU/olc6502.cpp#L1580

To fix this in Java I did a explicit cast to byte, unfortunately I don't know how to do in C++...

For example, here in the video it should be BNE #$FA [$8010] {REL} instead of BNE #$FA [$8110] {REL}
image

@OneLoneCoder
Copy link
Owner

The next video touches on this, so keep watching!

@fabriciorby
Copy link
Author

The next video touches on this, so keep watching!

Oh, of course! Thanks for reply and all content, and sorry for opening this issue then :p

@fabriciorby fabriciorby closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants