Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left clicking link on Locked tab results in 2 new tabs and stealing focus (FF 127 Final) #306

Closed
Insearchof18 opened this issue Jun 17, 2024 · 10 comments

Comments

@Insearchof18
Copy link

First time posting on github (just created my account lol), so apologies if I make any mistakes in reporting this issue! :)

After updating to Firefox 127, I started experiencing the above issue (tested on a system with 126.0.1 with latest TMP and everything's working perfectly). What was happening before the update with Locked tabs was that a single new tab would open with the resulting page and would not steal focus (middle-clicking a link still results in this correct behaviour).

To test, I installed a fresh copy of FF 127 (new profile) on a different machine that didn't have it (no other extensions installed), followed the instructions (https://onemen.github.io/tabmixplus-docs/other/installation/) from scratch to install TMP (tested with both the latest and the dev releases), and using the default TMP settings (without making any changes), I was able to replicate the issue. All tests done on Windows 10 x64 (22H2) systems.

Please let me know if any further info is needed for troubleshooting!

@onemen
Copy link
Owner

onemen commented Jun 17, 2024

try the latest dev-build

  • Provide an example to a page with this issue
  • Any message in the Browser console?
  • attach a file with you Tab Mix Plus preferences

@Insearchof18
Copy link
Author

Insearchof18 commented Jun 17, 2024

hey @onemen, thank you so much for the speedy response (and appreciate all your hard work on this project over the years)! :)

The dev build that I tested with was the same one you linked (1.20.1-20240606.1715), so unfortunately that did not resolve.

  • Clicking any of the links on the Installation page I provided above will result in what I mentioned, but really any site with any link (regardless of whether it has additional attributes, etc.).
  • Sorry, not very familiar with using the console for troubleshooting, but if you can guide me on what info to get for you, I'd be happy to.
  • As mentioned, the settings for TMP are all defaults (when I was testing). However, I've attached a copy of my prefs as well, which obviously results in the same issue.

@Insearchof18
Copy link
Author

Sorry, attachment didn't get added for some reason!

TMPpref.txt

@onemen
Copy link
Owner

onemen commented Jun 17, 2024

@Insearchof18,

Thank you for the information.

I can reproduce this error with your preference. I will try to fix it tomorrow

@Insearchof18
Copy link
Author

You're awesome, @onemen!! Thank you so much for your help!! :D

@onemen
Copy link
Owner

onemen commented Jun 17, 2024

tab_opening

The issue is with the 'Links' preference above, when you enable it, the issue is gone.
I will investigate more tomorrow.

@Insearchof18
Copy link
Author

You're a 100% right, I can confirm (both with my settings and clean install/profile/default settings for TMP)!

Great progress!! 👍🏽

@dxzy
Copy link

dxzy commented Jun 17, 2024

Same problem,
not open Link Focus/ Lock this tabs→left click link→two tab & steal focus,
middle click→one tab & not steal focus,
if open Link Foucus setup left click→one tab,but i don't want steal focus.

@onemen
Copy link
Owner

onemen commented Jun 18, 2024

This was a regression from commit ba7df31

Download and install the latest dev-build from today

@Insearchof18
Copy link
Author

Thank you so much, @onemen!! Works perfectly again!!

For anyone who was having the same issue and tries updating to the latest dev build but still has issues, I had to follow all of the steps from the installation instructions page (https://onemen.github.io/tabmixplus-docs/other/installation/) again before it started working properly for me (this was both on my main install and on my test machine with all defaults).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants