Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade grpc #801

Merged
merged 14 commits into from Dec 21, 2020
Merged

feat: upgrade grpc #801

merged 14 commits into from Dec 21, 2020

Conversation

Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Dec 18, 2020

What this PR does:

Updates gRPC and adds a dockerized make command to generate it.
Run make api-docker

Which issue(s) this PR fixes:

Fixes #800

Special notes for your reviewer:

Checklist

Please check if applies

  • I have added/updated relevant unit tests
  • I have added/updated relevant documentation

Required

  • I accept to release these changes under the Apache 2.0 License

@Vafilor Vafilor added this to the v0.17.0 milestone Dec 18, 2020
@Vafilor Vafilor changed the title Feat/upgrade.grpc feat: upgrade grpc Dec 21, 2020
@aleksandrmelnikov
Copy link
Contributor

Tested this on the branch, and output looks good. The output matched what was already committed, so that's a great reproducibility success.

The code looks good to me.

@aleksandrmelnikov
Copy link
Contributor

I'll be able to test it against my GRPC wrapper end points as well.

@Vafilor Vafilor merged commit 54580a7 into onepanelio:master Dec 21, 2020
@Vafilor Vafilor deleted the feat/upgrade.grpc branch December 21, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerize make api command for core
2 participants