Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS and Android idsAvailable return values not consistent #42

Closed
tonyxiao opened this issue Jun 13, 2016 · 2 comments
Closed

iOS and Android idsAvailable return values not consistent #42

tonyxiao opened this issue Jun 13, 2016 · 2 comments

Comments

@tonyxiao
Copy link

tonyxiao commented Jun 13, 2016

on iOS we return

NSDictionary *value = @{
                                    @"pushToken": pushToken,
                                    @"playerId" : userId
                                    };
            callback(@[value]);

On Android we return

final WritableMap value = Arguments.createMap();
                    value.putString("userId", userId);
                    value.putString("pushToken", registrationId);

                    callback.invoke(value);

We should return either userId or playerId and keep it the same on both platforms for consistency

@tonyxiao tonyxiao changed the title iOS and Android idsAvailable not consistent iOS and Android idsAvailable return values not consistent Jun 13, 2016
@avishayil
Copy link
Contributor

Thanks for the heads-up, i'll take care of it.

@avishayil
Copy link
Contributor

Fixed by 1.1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants