Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect types in API response #52

Open
lfkeitel opened this issue Apr 9, 2018 · 1 comment
Open

Incorrect types in API response #52

lfkeitel opened this issue Apr 9, 2018 · 1 comment

Comments

@lfkeitel
Copy link
Member

lfkeitel commented Apr 9, 2018

Several returned properties in an API call are using the wrong types. In particular many integers are being returned as a string. Or a boolean being returned as a string. In JavaScript it's not a big deal because JS will convert as needed, but it causes issues in typed languages.

These fixes will not be considered a breaking change because it's a bug fix.

@lfkeitel lfkeitel added the bug label Apr 9, 2018
@lfkeitel
Copy link
Member Author

lfkeitel commented Apr 9, 2018

On second thought, there's too much that needs to be fixed. A new versioned API will be written that provides the same functionality, but in a cleaner way. Better typing, better responses, use headers for authentication. /api/v2.

@lfkeitel lfkeitel added enhancement and removed bug labels Apr 9, 2018
@lfkeitel lfkeitel added this to the Version 7.0.0 milestone Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant