You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You've changed Image to KFCrossPlatformImage along with a bunch of other symbol names in 754ec2e#diff-650b8c6577862696b42f0418207910de without bumping a major version (you've bumped a minor/patch version 5.8.10).
This breaks semantic versioning. Libraries that depend on your framework are broken. Source-breaking changes should not be a path/minor version bump.
It seems you've also made a bunch of other non-backwards-compatible changes to this library. I'd like to understand what's the versioning scheme you follow here. As a library maintainer there should be a clear versioning system so other consumers can count on the Major/Minor/Patch system while designing their own solutions/apps that depend on your library.
Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.
Issue Description
What
You've changed
Image
toKFCrossPlatformImage
along with a bunch of other symbol names in 754ec2e#diff-650b8c6577862696b42f0418207910de without bumping a major version (you've bumped a minor/patch version 5.8.10).This breaks semantic versioning. Libraries that depend on your framework are broken. Source-breaking changes should not be a path/minor version bump.
It seems you've also made a bunch of other non-backwards-compatible changes to this library. I'd like to understand what's the versioning scheme you follow here. As a library maintainer there should be a clear versioning system so other consumers can count on the Major/Minor/Patch system while designing their own solutions/apps that depend on your library.
Here's one example of this:
RxSwiftCommunity/RxKingfisher#17
The text was updated successfully, but these errors were encountered: