Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Semantic Versioning #1303

Closed
3 tasks done
freak4pc opened this issue Oct 4, 2019 · 3 comments
Closed
3 tasks done

Broken Semantic Versioning #1303

freak4pc opened this issue Oct 4, 2019 · 3 comments

Comments

@freak4pc
Copy link

freak4pc commented Oct 4, 2019

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

Issue Description

What

You've changed Image to KFCrossPlatformImage along with a bunch of other symbol names in 754ec2e#diff-650b8c6577862696b42f0418207910de without bumping a major version (you've bumped a minor/patch version 5.8.10).

This breaks semantic versioning. Libraries that depend on your framework are broken. Source-breaking changes should not be a path/minor version bump.

It seems you've also made a bunch of other non-backwards-compatible changes to this library. I'd like to understand what's the versioning scheme you follow here. As a library maintainer there should be a clear versioning system so other consumers can count on the Major/Minor/Patch system while designing their own solutions/apps that depend on your library.

Here's one example of this:
RxSwiftCommunity/RxKingfisher#17

@onevcat
Copy link
Owner

onevcat commented Oct 4, 2019

It's an accident. I will make it compatible again in the next patch later today. Sorry for the inconvenience it caused!

@freak4pc
Copy link
Author

freak4pc commented Oct 4, 2019

No worries at all, just wanted to make sure if we should release a patch on our side or wait for a new release. Thank you so much 🙏 !

@onevcat
Copy link
Owner

onevcat commented Oct 4, 2019

Version 5.8.2 was released for this. Now if you resolve the Kingfisher version to 5.8.2, your code should work as is.

@onevcat onevcat closed this as completed Oct 4, 2019
@onevcat onevcat pinned this issue Oct 9, 2019
@onevcat onevcat unpinned this issue Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants