Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KingfisherManager.shared warning on Xcode 15.3 with Strict Concurrency Checking set to complete #2229

Closed
3 tasks done
diogot opened this issue Apr 8, 2024 · 4 comments
Closed
3 tasks done

Comments

@diogot
Copy link

diogot commented Apr 8, 2024

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

Issue Description

Xcode 15.3 add extra Swift 6 warnings when Strict Concurrency Checking is set to complete, one of those is on KingfisherManager.shared.

What

Screenshot 2024-04-08 at 08 45 49

Reproduce

  • Open the project on Xcode 15.3
  • Set Strict Concurrency Checking to Complete in the project
  • Compile
@onevcat
Copy link
Owner

onevcat commented Apr 12, 2024

We have some progress on fully supporting of concurrency in the upcoming major release, which is now on the v8 branch. However, the fully Strict Concurrency compatible is still a long-term target for now. There are some key features lacked in the current Swift concurrency model (for example, the isolated deinit).

@diogot
Copy link
Author

diogot commented Apr 18, 2024

Looking forward to it, thanks!

@onevcat
Copy link
Owner

onevcat commented Apr 28, 2024

Full strict concurrency checking has been implemented, and a pull request has been submitted as #2241. With further refinement, we should be able to release a beta version of the new major update for Kingfisher.

Please allow me to close this issue for now.

@onevcat onevcat closed this as completed Apr 28, 2024
@diogot
Copy link
Author

diogot commented Apr 29, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants