[NFC] Silence String.character access warning #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of String.character is now unnecessary as String is a sliceable collection all its own in Swift 4.
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 13 13
Lines 549 549
=======================================
Hits 505 505
Misses 44 44
Continue to review full report at Codecov.
|
|
Any chance for a merge of this, @onevcat? |
|
Merged and released as 3.0.1. |
|
Thanks a bunch, @onevcat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of String.character is now unnecessary as String is a sliceable collection all its own in Swift 4. This patch removes accesses to the
characterscollection and, in doing so, silences the warnings for its usage that appear in Xcode 9.1.