Change expiry_soon_days and expiry_critical_days

[hyanwong]

We decided that expiry_soon_days should default to 30 and expiry_critical_days should default to 1015. They need setting here:

OZtree/modules/sponsorship.py

Line 54 in 41fac8e

out['expiry_soon_days'] = 90

When doing this, is there any constraint on what we should set expiry_hysteresis to, @lentinj ?

It's not critical to do this now, because we will override it on the server using appconfig.ini, but it would avoid confusion to change the defaults in the code to what we expect.

[lentinj]

Beyond the obvious "make sure the regions don't overlap as a result", I don't think so. What they actually do is:

OZtree/modules/sponsorship.py

Lines 740 to 743 in 41fac8e

	expiry_soon_date = sponsorship_expiry_soon_date()
	expiry_soon_trigger = expiry_soon_date - datetime.timedelta(days=sponsorship_config()['expiry_hysteresis'])
	expiry_critical_date = sponsorship_expiry_soon_date('critical')
	expiry_critical_trigger = expiry_critical_date - datetime.timedelta(days=sponsorship_config()['expiry_hysteresis'])

The first date decides that they appear in an e-mail, the second triggers the e-mail to actually be sent (and thus batching the 10 days' worth of alerts).

[hyanwong]

Also it would be good to add a comment with a little more explanation of the expiry_hysteresis value, e.g. using a practical example, as it's not obvious ATM. E.g.

"If expiry_soon_days is 30 and expiry_hysteresis=5, then when the script is run anything exciting between 30 and 25 days will be considered as expiring soon". Is that correct @lentinj ?

[lentinj]

"If expiry_soon_days is 30 and expiry_hysteresis=5, then an e-mail will be sent when any sponsorship has 25 days left. This e-mail will include any other sponsorships with 25..30 days left - these won't get a separate e-mail once they hit 25 days left.".