Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Network connection failure for polling requests #1634

Closed
mordochi opened this issue Apr 27, 2023 · 8 comments
Closed

[BUG] Network connection failure for polling requests #1634

mordochi opened this issue Apr 27, 2023 · 8 comments
Assignees
Labels
Bug Something isn't working Seen 👀 This Issue has been seen by the Flow-JS-SDK Maintainers and they are thinking about it.

Comments

@mordochi
Copy link
Contributor

mordochi commented Apr 27, 2023

Current Behavior

Related issue: #1582

Thanks again for helping with the issue :)

I've just tested the fix but unfortunately PR #1623 doesn't seem to fix all the login issue. It does reduce the chances that the wallet closes unintentionally(but still happens if you leave the browser for a longer time). However, when I proceed to type the OTP code and move on to the confirm page, the result is never resolved.

More details and a possible solution are commented in the previous issue: #1582 (comment)

Expected Behavior

  • The wallet iframe should not close after the user leaves the browser and then come back again
  • After the user types the OTP code and get to the confirm page, the login result should be resolved when the approve button is clicked, which means the polling requests should still keep sending and fetch back the result

Steps To Reproduce

  1. Login with a dApp integrating with Blocto wallet through the back-channel communication with accessNode.api as https://wallet-v2-dev.blocto.app/api/flow/authn
  2. Types the email
  3. Leave the browser for a while to check on the OTP code
  4. Come back to the browser and you may find the wallet iframe is closed, or the iframe is still there but not resolved with the login result

Environment

on iOS Safari

What are you currently working on that this is blocking?

The back-channel communication between FCL and Blocto wallet

@mordochi mordochi added the Bug Something isn't working label Apr 27, 2023
@scottphc
Copy link

@JeffreyDoyle @justinbarry @chasefleming Need your help to check this issue

@JeffreyDoyle JeffreyDoyle added the Seen 👀 This Issue has been seen by the Flow-JS-SDK Maintainers and they are thinking about it. label Apr 27, 2023
@JeffreyDoyle JeffreyDoyle self-assigned this Apr 27, 2023
@JeffreyDoyle
Copy link
Member

Hey @mordochi @scottphc - Thank you for this issue and also for the suggested solution (#1582 (comment)). We're going to take a look a respond back when we have a solution/implementation or an update!

@mordochi
Copy link
Contributor Author

Hey @mordochi @scottphc - Thank you for this issue and also for the suggested solution (#1582 (comment)). We're going to take a look a respond back when we have a solution/implementation or an update!

Great! Thank you so much 😄

@JeffreyDoyle
Copy link
Member

Hi @mordochi - closing this as the PR with a solution has been merged (#1640) with the suggested solution. We will release the fix shortly!

@JeffreyDoyle
Copy link
Member

Hi @mordochi - we have released the fix for this issue, please try using @onflow/fcl@1.4.00-alpha.9 . If the issue persists for you, please reopen this issue!

@mordochi
Copy link
Contributor Author

Hi @JeffreyDoyle, we've tried the fix and it works. Thank you so much for helping with this issue!

@JeffreyDoyle
Copy link
Member

Hey @mordochi @scottphc - we just released @onflow/fcl@1.4.0 which includes this fix! 😄

@scottphc
Copy link

scottphc commented Jun 3, 2023

Hey @mordochi @scottphc - we just released @onflow/fcl@1.4.0 which includes this fix! 😄

Awesome! Very appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Seen 👀 This Issue has been seen by the Flow-JS-SDK Maintainers and they are thinking about it.
Projects
None yet
Development

No branches or pull requests

3 participants