Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Buffer issue building with parcel #1649

Closed
Tracked by #1650
chasefleming opened this issue May 15, 2023 · 0 comments
Closed
Tracked by #1650

[BUG] Buffer issue building with parcel #1649

chasefleming opened this issue May 15, 2023 · 0 comments
Assignees
@nialexsan
Labels
Bug Something isn't working

Comments

@chasefleming
Copy link
Member

Current Behavior

Screenshot 2023-05-10 at 12 21 17 PM

Had to install buffer v5 to build with parcel. When it was missing or v6 this error occurred.

Expected Behavior

Buffer should be polyfilled in FCL and not required

Steps To Reproduce

  1. Clone this repo https://github.com/chasefleming/flipping
  2. Remove the "buffer" dependency or update it to v6
  3. Try running npm run build:widget

Environment

- OS:
- Node:
- npm:

What are you currently working on that this is blocking?

No response
@chasefleming chasefleming added the Bug Something isn't working label May 15, 2023
@chasefleming chasefleming changed the title [BUG] Buffer issue running with parcel [BUG] Buffer issue building with parcel May 15, 2023
@chasefleming chasefleming mentioned this issue May 15, 2023
Open
7 tasks
@chasefleming chasefleming removed their assignment May 16, 2023
@nialexsan nialexsan mentioned this issue Jul 6, 2023
Merged
@jribbink jribbink closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nialexsan nialexsan

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chasefleming @nialexsan @jribbink