Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [release-typescript] JSDoc regression #1779

Closed
jribbink opened this issue Sep 14, 2023 · 0 comments · Fixed by #1780
Closed

[BUG] [release-typescript] JSDoc regression #1779

jribbink opened this issue Sep 14, 2023 · 0 comments · Fixed by #1780
Assignees
@jribbink
Labels
Bug Something isn't working

Comments

@jribbink
Copy link
Contributor

Current Behavior

(this is a problem on the release-typescript branch and not master)

With the addition of typescript to the build process, we have regressed in JSDoc type generation. These types are no longer getting generated & only TS files have their corresponding .d.ts made.

Expected Behavior

Should generate .d.ts for both js & ts

Steps To Reproduce

Build on that branch with a js file imported.

Environment

n/a

What are you currently working on that this is blocking?

No response
@jribbink jribbink added the Bug Something isn't working label Sep 14, 2023
@jribbink jribbink self-assigned this Sep 14, 2023
@jribbink jribbink mentioned this issue Sep 14, 2023
Merged
@jribbink jribbink linked a pull request Sep 14, 2023 that will close this issue
Fix JSDoc type generation #1780
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jribbink jribbink

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix JSDoc type generation onflow/fcl-js
1 participant
@jribbink