Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[State sync engine] Add new "ExecutionDataCID" field to ExecutionResult #1451

Closed
synzhu opened this issue Oct 6, 2021 · 2 comments · Fixed by #1775
Closed

[State sync engine] Add new "ExecutionDataCID" field to ExecutionResult #1451

synzhu opened this issue Oct 6, 2021 · 2 comments · Fixed by #1775
Assignees
Labels

Comments

@synzhu
Copy link
Contributor

synzhu commented Oct 6, 2021

Add a ExecutionDataCID field to execution result, so that consensus followers can know how to request the state diff for a given block over bitswap.

Each time an execution node computes a new ExecutionData for a block, it can forward it to the ExecutionDataStorer to be stored into the blockstore, and include the returned CID in the execution result.

Note: This may introduce additional latency / CPU usage on execution nodes, we should benchmark to see how much the performance impact will be.

@synzhu synzhu self-assigned this Oct 6, 2021
@synzhu synzhu mentioned this issue Oct 7, 2021
1 task
@huitseeker
Copy link
Contributor

Note that the verifiability of the CID in question will eventually need to be checked by verification nodes, but we can do something faster for the moment, which is to check the data against the authoritative hashes contained in the ExecutionReceipt post download. More details here:
https://www.notion.so/dapperlabs/State-sync-engine-bed32c0caba94913b21925f6bc090aaf#d4ef9d5452424412b69f149e40ad35d1

@synzhu synzhu changed the title [State sync engine] Add new "StateDiffCID" field to ExecutionResult [State sync engine] Add new "ExecutionDataCID" field to ExecutionResult Nov 16, 2021
@synzhu
Copy link
Contributor Author

synzhu commented Nov 16, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants