Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert decoding of past block types #5936

Open
Tracked by #5918
sideninja opened this issue May 16, 2024 · 0 comments
Open
Tracked by #5918

Revert decoding of past block types #5936

sideninja opened this issue May 16, 2024 · 0 comments
Assignees

Comments

@sideninja
Copy link
Member

sideninja commented May 16, 2024

We need to revert the logic for decoding previous types of blocks. During development block type was changed (new fields were added), and because blocks were persisted on previewnet we have to handle decoding different types of blocks, but once previewnet is gone there's no other chain persisting previous types of blocks so decoding logic can be removed.

This code needs to be removed: https://github.com/onflow/flow-go/blob/master/fvm/evm/types/block.go#L198-L267

@sideninja sideninja self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant