Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-install the Flow CLI #40

Open
psiemens opened this issue May 2, 2022 · 1 comment
Open

Auto-install the Flow CLI #40

psiemens opened this issue May 2, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@psiemens
Copy link
Contributor

psiemens commented May 2, 2022

Freshmint currently requires the Flow CLI (flow binary) to be installed in order to deploy contracts or mint NFTs.

The Flow CLI is not installed alongside Freshmint but is mentioned as a dependency in the README. This is a weak connection.

Freshmint should do one of the following:

  1. Stop depending on the flow binary and implement transaction/script logic in JS
  2. Automatically install the flow binary on installation
@psiemens psiemens added the enhancement New feature or request label May 2, 2022
@psiemens psiemens self-assigned this May 2, 2022
@psiemens
Copy link
Contributor Author

psiemens commented Oct 6, 2022

I'd like to go with option 2 because it allows Freshmint users to eject from Freshmint and use their project directly with the Flow CLI.

It's fairly easy to install platform-specific Go binaries in an NPM postinstall script: https://blog.xendit.engineer/how-we-repurposed-npm-to-publish-and-distribute-our-go-binaries-for-internal-cli-23981b80911b

@psiemens psiemens changed the title Remove implicit dependency on Flow CLI Auto-install the Flow CLI Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant