Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve codelens refresh #218

Closed
sideninja opened this issue Jan 9, 2023 · 0 comments · Fixed by #309
Closed

Improve codelens refresh #218

sideninja opened this issue Jan 9, 2023 · 0 comments · Fixed by #309
Assignees
Labels

Comments

@sideninja
Copy link
Member

Codeless are currently refreshed by adding and removing a space in a file as seen here

export const refreshCodeLenses = (): void => {

This is not a great implementation and it would be better to research how to trigger an update by calling the LS client directly. The cons of current implementations are:

  • the codelenss are requested twice (one for adding space one for removing) which creates extra load
  • whenever you just open a project file and then close it, it always asks you whether you want to save which is really confusing because you didn't create a change
  • is just very fragile imho
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants