Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove() method for manager #486

Closed
mvar opened this issue Dec 7, 2015 · 2 comments
Closed

Add remove() method for manager #486

mvar opened this issue Dec 7, 2015 · 2 comments
Assignees
Milestone

Comments

@mvar
Copy link
Member

mvar commented Dec 7, 2015

Here is no easy way to remove document from ES when you have only document object. It would be nice to have method in Manager service:

public function remove(DocumentInterface $document);

This method should add delete operation to bulk request body.

@saimaz
Copy link
Member

saimaz commented Dec 7, 2015

There is similar method already:

public function remove($id)

@mvar
Copy link
Member Author

mvar commented Dec 7, 2015

Similar in purpose, but there are two differences in usage:

  1. To use Repository::remove() you need to have repository service or to know document type.
  2. Repository::remove() directly calls ES. In some cases would be nice to use bulk request.

I think we should implement Manager::remove() as I suggested. Not sure about method in Repository class. As ESB was created with objects in mind maybe we should remove it.

@saimaz saimaz added this to the 1.0.0 milestone Dec 31, 2015
@mvar mvar self-assigned this Jan 5, 2016
@mvar mvar added the qa label Jan 5, 2016
@saimaz saimaz removed the qa label Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants