Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$params was never been initialized in function #45

Closed
saimaz opened this issue Nov 24, 2014 · 0 comments · Fixed by #66
Closed

$params was never been initialized in function #45

saimaz opened this issue Nov 24, 2014 · 0 comments · Fixed by #66
Assignees
@martiis

Comments

@saimaz
Copy link
Member

saimaz commented Nov 24, 2014

$params was never initialized. Although not strictly required by PHP, it is generally a good practice to add $params = array(); before regardless.

see https://scrutinizer-ci.com/g/ongr-io/ElasticsearchBundle/issues/master/files/Client/Connection.php?selectedLabels%5B0%5D=3&orderField=path&order=asc#inspectioncomment-356280567
@saimaz saimaz added the planned label Nov 24, 2014
@tautrimas tautrimas added ready and removed ready labels Dec 4, 2014
@martiis martiis mentioned this issue Dec 8, 2014
Merged
@martiis martiis self-assigned this Dec 8, 2014
@saimaz saimaz removed the ready label Dec 8, 2014
@martiis martiis self-assigned this Dec 8, 2014
@martiis martiis added go and removed ready labels Dec 8, 2014
@saimaz saimaz removed the go label Dec 8, 2014
@martiis martiis added qa and removed in progress labels Dec 8, 2014
@martiis martiis removed the qa label Dec 8, 2014
martiis pushed a commit that referenced this issue Dec 8, 2014
Merge pull request #66 from martiis/issue45
9d0ebf4 
$params initialization in method, Closes #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martiis martiis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

$params initialization in method, Closes #45
3 participants
@saimaz @tautrimas @martiis