Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

QuickOpen: Ctrl-P / QuickOpen menu only works with git #47

Closed
bryphe opened this issue Dec 8, 2016 · 1 comment
Closed

QuickOpen: Ctrl-P / QuickOpen menu only works with git #47

bryphe opened this issue Dec 8, 2016 · 1 comment
Assignees
Milestone

Comments

@bryphe
Copy link
Member

bryphe commented Dec 8, 2016

Right now, the QuickOpen menu only works with git. The code for finding files looks like this:

oni/browser/src/Services/QuickOpen.ts

    const trackedFiles = execSync("git ls-files").toString("utf8").split("\n")
    const untrackedFiles = execSync("git ls-files --others --exclude-standard").toString("utf8").split("\n")

It would be helpful to have, at the very least, a fallback strategy to use a node module for recursively traversing the file structure. In addition, having the command line be a user-configurable option would be really helpful - so people can use the preferred search tool of their choice (ag, grep, etc).

@bryphe
Copy link
Member Author

bryphe commented Dec 15, 2016

Fixed by #97

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant