Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Oni open binaries will cause crash #473

Closed
gynet opened this issue Jun 2, 2017 · 4 comments · Fixed by #797
Closed

Oni open binaries will cause crash #473

gynet opened this issue Jun 2, 2017 · 4 comments · Fixed by #797

Comments

@gynet
Copy link

gynet commented Jun 2, 2017

If a user uses Oni to open a binary, e.g Oni.exe, node.dll in the package, it will crash within seconds.

@gynet gynet changed the title Oni open binary will cause crash Oni open binaries will cause crash Jun 2, 2017
@bryphe
Copy link
Member

bryphe commented Jun 3, 2017

Thanks for logging the issue! I'm assuming you're on Windows?

I'm able to reproduce as well on Windows 10. It looks like Oni gets the disconnect even from Neovim (which I believe means the neovim process died).

This doesn't reproduce in nvim-qt.exe - so I'm wondering if it is related to the default / core set of plugins we use for Oni integration. In particular, the buffer update might be causing problems for these large binary files.

@bryphe bryphe added this to the Backlog milestone Jun 3, 2017
@gynet
Copy link
Author

gynet commented Jun 3, 2017

Yes, I am using Windows 10

@keforbes
Copy link
Collaborator

keforbes commented Jun 5, 2017

Interesting, this isn't a problem on Linux; it loads binary files just fine. I tried with nvim.exe, which is 3.8MB so I don't think large file sizes are a problem. I wonder if this issue only occurs on Windows.

@cyansprite
Copy link
Contributor

I will look into this too since I am making a plugin and it sometimes opens very, very large files :).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants