Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parser to fetch Emojis #17

Merged
merged 7 commits into from Aug 16, 2019
Merged

Fix parser to fetch Emojis #17

merged 7 commits into from Aug 16, 2019

Conversation

vinayjn
Copy link
Contributor

@vinayjn vinayjn commented Aug 16, 2019

Merging this PR will make the following changes

  • Migrate to Swift 5
  • Change version number to 2.0.1
  • Fix the parser file to generate Emoji.swift and Category.swift, because the categories JSON is not found on the CDN.

@vinayjn
Copy link
Contributor Author

vinayjn commented Aug 16, 2019

@onmyway133 @Francescu can you please review this?

@onmyway133 onmyway133 merged commit 10802e3 into onmyway133:master Aug 16, 2019
@onmyway133
Copy link
Owner

@vinayjn Look good to me, thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants